2015-09-28 12:00 GMT+03:00 Dmitry Vyukov <[email protected]>:
> stack = (unsigned long)task_stack_page(p);
> - if (p->thread.sp < stack || p->thread.sp >= stack+THREAD_SIZE)
> + /* The task can be already running at this point, so tread carefully.
> */
> + fp = READ_ONCE(p->thread.sp);
> + if (fp < stack || fp >= stack+THREAD_SIZE)
Since we deference fp, it should be "|| fp + sizeof(u64) >= stack + THREAD_SIZE"
> return 0;
> - fp = *(u64 *)(p->thread.sp);
> + fp = READ_ONCE(*(u64 *)fp);
> do {
> if (fp < (unsigned long)stack ||
> - fp >= (unsigned long)stack+THREAD_SIZE)
> + fp+8 >= (unsigned long)stack+THREAD_SIZE)
The same as above;
'fp+8 +sizeof(u64) >= ...'
> return 0;
> - ip = *(u64 *)(fp+8);
> + ip = READ_ONCE(*(u64 *)(fp+8));
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
