On Tue, Sep 29, 2015 at 12:50 PM, Peter Zijlstra <pet...@infradead.org> wrote: > > The control dependency creates a LOAD->STORE order, that is, no STOREs > can happen until we observe !p->on_cpu.
Fair enough. > Right, but wmb isn't sufficient as it doesn't order the prev->state LOAD > vs the prev->on_cpu = 0 STORE. If those happen in the wrong order the > described race can happen and we get a use-after-free. .. and you convinced me. The patch is good. Ack. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/