On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
I do not consider this an improvement in any way and suggest this patch is dropped. > --- > > drivers/mfd/lm3533-core.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > index 643f3750e830..193ecee1fa7e 100644 > --- a/drivers/mfd/lm3533-core.c > +++ b/drivers/mfd/lm3533-core.c > @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533, > if (ret) > return ret; > > - ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > - if (ret) > - return ret; > - > - return 0; > + return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); You're saving a few lines of code but instead introduce asymmetries and obscure the fact that the function returns zero on success. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
