The current implementation uses both 'grep' and 'awk' for text processing here, which may be alright as a quick solution to be run on the command line. While in a script, 'sed' or 'awk' would be a better choice. On top of that, the current implementation expects the version number to be found in field 3 as seen by 'awk'. Should the output format be different, this approach would no longer be reliable.
The proposed implementation uses 'sed' as a more flexible tool to handle varying output formats. Tested on: Arch Linux Signed-off-by: Alexander Kapshuk <alexander.kaps...@gmail.com> --- --- linux/scripts/ver_linux.orig 2015-08-30 21:34:09.000000000 +0300 +++ linux/scripts/ver_linux 2015-09-30 22:50:41.528887446 +0300 @@ -50,8 +50,12 @@ quota -V 2>&1 | grep version | awk \ 'NR==1{print "quota-tools ", $NF}' -pppd --version 2>&1| grep version | awk \ -'NR==1{print "PPP ", $3}' +pppd --version 2>&1 | +sed ' + /version/!d + s/[^0-9\.]//g + s/^/PPP\t\t\t/ +' isdnctrl 2>&1 | grep version | awk \ 'NR==1{print "isdn4k-utils ", $NF}' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/