On Wed, Oct 07, 2015 at 12:00:47PM +0100, Srinivas Kandagatla wrote: > As required by many providers like at24/at25/mxs-ocotp/qfprom and may be > other providers would want to allow root-only to read the nvmem content. > So making the defaults to be root-only access would address the request > and also provide flexibility to providers to specify there own permissions > on top of the root-only using the perm flag in nvmem_config.
Eeek, no, don't mess with different permissions, that's not ok, be consistent and only allow root write access, that's why we have static build-time checks to ensure you get this correct and do not accidentally let a "normal" user access to things they shouldn't have access to. > Making this dynamic did cut down lot of static binary attributes in the > code. Nothing wrong with static binary attributes, please use them instead. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
