On Fri, Oct 02, 2015 at 02:18:58PM +0900, Namhyung Kim wrote:
SNIP
> +static int thread__clone_map_groups(struct thread *thread,
> + struct thread *parent);
> +
> int __thread__set_comm(struct thread *thread, const char *str, u64 timestamp,
> bool exec)
> {
> @@ -182,6 +257,40 @@ int __thread__set_comm(struct thread *thread, const char
> *str, u64 timestamp,
> unwind__flush_access(thread);
> }
>
> + if (exec) {
> + struct machine *machine;
> +
> + BUG_ON(thread->mg == NULL || thread->mg->machine == NULL);
> +
> + machine = thread->mg->machine;
> +
> + if (thread->tid != thread->pid_) {
> + struct map_groups *old = thread->mg;
> + struct thread *leader;
> +
> + leader = machine__findnew_thread(machine, thread->pid_,
> + thread->pid_);
> +
> + /* now it'll be a new leader */
> + thread->pid_ = thread->tid;
> +
> + thread->mg = map_groups__new(old->machine);
> + if (thread->mg == NULL)
> + return -ENOMEM;
hum, isn't this leaking thread->mg ?
should we call map_groups__put(old) at the end of block?
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
