Quoting Eric W. Biederman ([EMAIL PROTECTED]): > This patch refactors the ipc sysctl support so that it is > simpler, more readable, and prepares for fixing the bug > with the wrong values being returned in the sys_sysctl interface. > > The function proc_do_ipc_string was misnamed as it never handled > strings. It's magic of when to work with strings and when to work > with longs belonged in the sysctl table. I couldn't tell if the > code would work if you disabled the ipc namespace but it certainly > looked like it would have problems. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
Hi, A little belated (sorry), but the only comment I have right now on the patchset is that the get_ipc() seems like it shouldn't take the write arg. Perhaps if consistency is the concern, get_uts() should simply be called get_uts_locked(table, need_write) ? This also avoids the mysterious '1' argument in the next patch at get_ipc(table, 1); Oh, I lied, one more comment. It seems worth a comment at the top of get_uts() and get_ipc() explaining that table->data points to init_uts->data and that's why the 'which = which - init_uts + uts' works. thanks, -serge - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
