Andy,
On Fri, 9 Oct 2015, Andy Shevchenko wrote:
> #ifdef CONFIG_PCI
> static void mem32_serial_out(unsigned long addr, int offset, int value)
> {
> - u32 *vaddr = (u32 *)addr;
> + void __iomem *vaddr = (void __iomem *)addr;
> /* shift implied by pointer type */
> writel(value, vaddr + offset);
This is broken. Assume vaddr = 0x1000 and offset = 1
==> u32 *vaddr = 0x1000;
==> vaddr + offset = 0x1004
with your change
==> void __iomem *vaddr = 0x1000;
==> vaddr + offset = 0x1001
This comment is there for a reason:
> /* shift implied by pointer type */
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
