Hi Colin, This looks good. Out of curiousity, how did you find it? Code inspection? Bug? Static analysis?
Not that it's particularly meaningful for such a trivial fix, but FWIW: Reviewed-by: Daniel Axtens <d...@axtens.net> Regards, Daniel Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > pi_buff is being memset before it is sanity checked. Move the > memset after the null pi_buff sanity check to avoid an oops. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- > arch/powerpc/platforms/pseries/hvcserver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/hvcserver.c > b/arch/powerpc/platforms/pseries/hvcserver.c > index eedb645..94a6e56 100644 > --- a/arch/powerpc/platforms/pseries/hvcserver.c > +++ b/arch/powerpc/platforms/pseries/hvcserver.c > @@ -142,11 +142,11 @@ int hvcs_get_partner_info(uint32_t unit_address, struct > list_head *head, > int more = 1; > int retval; > > - memset(pi_buff, 0x00, PAGE_SIZE); > /* invalid parameters */ > if (!head || !pi_buff) > return -EINVAL; > > + memset(pi_buff, 0x00, PAGE_SIZE); > last_p_partition_ID = last_p_unit_address = ~0UL; > INIT_LIST_HEAD(head); > > -- > 2.5.0 > > _______________________________________________ > Linuxppc-dev mailing list > linuxppc-...@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
signature.asc
Description: PGP signature
