On Fri, Oct 09, 2015 at 03:03:33PM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Thu, Oct 08, 2015 at 12:17:11PM +0200, Jiri Olsa wrote:
> > On Fri, Oct 02, 2015 at 02:18:43PM +0900, Namhyung Kim wrote:
> > > It is more convenient saving mmap length rather than (bit) mask. With
> > > this patch, we can eliminate dependency to perf_evlist other than
> > > getting mmap_desc for dealing with mmaps. The mask and length can be
> > > converted using perf_evlist__mmap_mask/len().
> > >
> > > Cc: Jiri Olsa <jo...@redhat.com>
> > > Cc: Adrian Hunter <adrian.hun...@intel.com>
> > > Signed-off-by: Namhyung Kim <namhy...@kernel.org>
> >
> > after this patch I'm hitting:
> >
> > [jolsa@krava perf]$ ./perf record kill
> > kill: not enough arguments
> > perf: util/evlist.c:1003: perf_evlist__mmap_len: Assertion `!((mask &
> > page_size) != 0)' failed.
> > Aborted (core dumped)
> > [jolsa@krava perf]$
>
> This is strange.. I think I fixed it already. And the expression in
> the assertion is different than the code in the patch:
>
> static size_t perf_evlist__mmap_len(size_t mask)
> {
> BUG_ON(((mask + 1) % page_size) != 0);
>
> return mask + 1 + page_size;
> }
>
> Could you please double check?
yep, that one still works.. I probably forked some older version
of your perf/threaded-v5.. the current one has it fixed already
will check the new one
thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
