<snip> >> +static unsigned instances = 1; >> +module_param(instances, uint, 0);
One concern about this. We will still create a default number of 'instances' when using configuration via configfs? I'm not sure we can remove this parameter once the module is moved out of staging, since we break the ABI (?) The rest looks good to me. I'm pretty sure that moving this out of staging will make the module more visible and people will jump with enhancements. thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
