On Sat, 10 Oct 2015, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression root,e; > local idexpression child; > iterator name for_each_child_of_node; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > + of_node_put(child); > ? break; > ... > } > ... when != child > // </smpl> > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > --- > drivers/video/backlight/88pm860x_bl.c | 1 + > 1 file changed, 1 insertion(+)
Applied, thanks. > diff --git a/drivers/video/backlight/88pm860x_bl.c > b/drivers/video/backlight/88pm860x_bl.c > index 2da5862..6d8dc2c 100644 > --- a/drivers/video/backlight/88pm860x_bl.c > +++ b/drivers/video/backlight/88pm860x_bl.c > @@ -180,6 +180,7 @@ static int pm860x_backlight_dt_init(struct > platform_device *pdev, > data->iset = PM8606_WLED_CURRENT(iset); > of_property_read_u32(np, "marvell,88pm860x-pwm", > &data->pwm); > + of_node_put(np); > break; > } > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
