On Mon, Oct 12, 2015 at 01:53:32PM +0200, Lukasz Odzioba wrote: > A new limit selected arbitrarily as power of two greater than > required minimum for Xeon Phi processor. > > Currently driver is not able to handle cores with core ID greater than 32. > Such attempt ends up with the following error in dmesg: > coretemp coretemp.0: Adding Core XXX failed >
Why 128 instead of a more reasonable 64 ? What is the required minimum for Xeon Phi ? Also, please consider using the subject line commonly used in hwmon, or at least point to the driver you are changing. Thanks, Guenter > Signed-off-by: Lukasz Odzioba <lukasz.odzi...@intel.com> > --- > drivers/hwmon/coretemp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c > index 3e03379..6a27eb2 100644 > --- a/drivers/hwmon/coretemp.c > +++ b/drivers/hwmon/coretemp.c > @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444); > MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius"); > > #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */ > -#define NUM_REAL_CORES 32 /* Number of Real cores per cpu > */ > +#define NUM_REAL_CORES 128 /* Number of Real cores per cpu > */ > #define CORETEMP_NAME_LENGTH 19 /* String Length of attrs */ > #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */ > #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1) > -- > 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
