On Mon, Oct 16, 2023 at 04:16:05PM +0800, Liu, Jingqi wrote:
> @@ -88,10 +90,19 @@ iommufd_hw_pagetable_alloc(struct iommufd_ctx *ictx,
> struct iommufd_ioas *ioas,
> refcount_inc(&ioas->obj.users);
> hwpt->ioas = ioas;
>
> - hwpt->domain = iommu_domain_alloc(idev->dev->bus);
> - if (!hwpt->domain) {
> - rc = -ENOMEM;
> - goto out_abort;
> + if (ops->domain_alloc_user) {
> + hwpt->domain = ops->domain_alloc_user(idev->dev, 0);
>
> Seems a "flags" parameter needs to be passed to 'domain_alloc_user()'.
> Like this:
> hwpt->domain = ops->domain_alloc_user(idev->dev, flags);
There's no "flags" parameter until the following PATCH-3:
https://lore.kernel.org/linux-iommu/[email protected]/
Thanks
Nicolin
