On 5/7/24 1:36 AM, Felix Huettner wrote:
>
> As long as we are looking at this, what do you think about
> this:
>
> diff --git a/tools/testing/selftests/netfilter/conntrack_dump_flush.c
> b/tools/testing/selftests/netfilter/conntrack_dump_flush.c
> index e9df4ae14e16..4a73afad4de4 100644
> --- a/tools/testing/selftests/netfilter/conntrack_dump_flush.c
> +++ b/tools/testing/selftests/netfilter/conntrack_dump_flush.c
> @@ -317,12 +317,12 @@ FIXTURE_SETUP(conntrack_dump_flush)
> self->sock = mnl_socket_open(NETLINK_NETFILTER);
> if (!self->sock) {
> perror("mnl_socket_open");
> - exit(EXIT_FAILURE);
> + SKIP(exit(EXIT_FAILURE), "mnl_socket_open() failed");
> }
>
> if (mnl_socket_bind(self->sock, 0, MNL_SOCKET_AUTOPID) < 0) {
> perror("mnl_socket_bind");
> - exit(EXIT_FAILURE);
> + SKIP(exit(EXIT_FAILURE), "mnl_socket_bind() failed");
> }
>
> ret = conntracK_count_zone(self->sock, TEST_ZONE_ID);
>
> ...which changes the above output, to:
>
> $ ./conntrack_dump_flush
> TAP version 13
> 1..3
> # Starting 3 tests from 1 test cases.
> # RUN conntrack_dump_flush.test_dump_by_zone ...
> mnl_socket_open: Protocol not supported
> # SKIP mnl_socket_open() failed
> # OK conntrack_dump_flush.test_dump_by_zone
> ok 1 conntrack_dump_flush.test_dump_by_zone # SKIP mnl_socket_open()
failed
> # RUN conntrack_dump_flush.test_flush_by_zone ...
> mnl_socket_open: Protocol not supported
> # SKIP mnl_socket_open() failed
> # OK conntrack_dump_flush.test_flush_by_zone
> ok 2 conntrack_dump_flush.test_flush_by_zone # SKIP mnl_socket_open()
failed
> # RUN conntrack_dump_flush.test_flush_by_zone_default ...
> mnl_socket_open: Protocol not supported
> # SKIP mnl_socket_open() failed
> # OK conntrack_dump_flush.test_flush_by_zone_default
> ok 3 conntrack_dump_flush.test_flush_by_zone_default # SKIP
> mnl_socket_open() failed
> # PASSED: 3 / 3 tests passed.
> # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:3 error:0
>
> ?
lgtm
OK, I'll send that out, appreciate your looking at it.
thanks,
--
John Hubbard
NVIDIA
