From: Geliang Tang <tanggeli...@kylinos.cn>

This patch uses public helper make_sockaddr() exported in network_helpers.h
instead of open-coding in sockmap_ktls.c. This can avoid duplicate code.

Acked-by: Eduard Zingerman <eddy...@gmail.com>
Signed-off-by: Geliang Tang <tanggeli...@kylinos.cn>
---
 .../selftests/bpf/prog_tests/sockmap_ktls.c      | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c 
b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
index a794aa688ab5..3c223601e8b6 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
@@ -59,23 +59,11 @@ static void 
test_sockmap_ktls_update_fails_when_sock_has_ulp(int family, int map
 {
        struct sockaddr_storage addr = {};
        socklen_t len = sizeof(addr);
-       struct sockaddr_in6 *v6;
-       struct sockaddr_in *v4;
        int err, s, zero = 0;
 
-       switch (family) {
-       case AF_INET:
-               v4 = (struct sockaddr_in *)&addr;
-               v4->sin_family = AF_INET;
-               break;
-       case AF_INET6:
-               v6 = (struct sockaddr_in6 *)&addr;
-               v6->sin6_family = AF_INET6;
-               break;
-       default:
-               PRINT_FAIL("unsupported socket family %d", family);
+       err = make_sockaddr(family, NULL, 0, &addr, &len);
+       if (!ASSERT_OK(err, "make_sockaddr"))
                return;
-       }
 
        s = socket(family, SOCK_STREAM, 0);
        if (!ASSERT_GE(s, 0, "socket"))
-- 
2.43.0


Reply via email to