On Fri, Aug 08, 2025 at 05:12:03PM -0700, Jakub Kicinski wrote:
> The test is implicitly assuming the device only has 2 queues.
> A real device will likely have more. The exact problem is that
> because NAPIs get added to the list from the head, the netlink
> dump reports them in reverse order. So the naive napis[0] will
> actually likely give us the _last_ NAPI, not the first one.
> Re-enable all the NAPIs instead of hard-coding 2 in the test.
> This way the NAPIs we operated on will always reappear,
> doesn't matter where they were in the registration order.
>
> Fixes: e6d76268813d ("net: Update threaded state in napi config in
> netif_set_threaded")
> Signed-off-by: Jakub Kicinski <[email protected]>
> ---
> tools/testing/selftests/drivers/net/napi_threaded.py | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Joe Damato <[email protected]>
