Re: [PATCH 19/33] dmaengine: ioat: Move system_has_dca_enabled() to dma.h

[Dave Jiang]

On 6/20/25 4:20 PM, David Matlack wrote:
> Move the function prototype for system_has_dca_enabled() from hw.h to
> dma.h. This allows hw.h to be included from tools/, which will be used
> in a subsysequent commit to implement a userspace driver for Intel CBDMA
> devices in tools/testing/selftests/vfio.
> 
> No functional change intended.
> 
> Signed-off-by: David Matlack <dmatl...@google.com>

Acked-by: Dave Jiang <dave.ji...@intel.com>
> ---
>  drivers/dma/ioat/dma.h | 2 ++
>  drivers/dma/ioat/hw.h  | 3 ---
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma.h b/drivers/dma/ioat/dma.h
> index a180171087a8..12a4a4860a74 100644
> --- a/drivers/dma/ioat/dma.h
> +++ b/drivers/dma/ioat/dma.h
> @@ -19,6 +19,8 @@
>  
>  #define IOAT_DMA_DCA_ANY_CPU         ~0
>  
> +int system_has_dca_enabled(struct pci_dev *pdev);
> +
>  #define to_ioatdma_device(dev) container_of(dev, struct ioatdma_device, 
> dma_dev)
>  #define to_dev(ioat_chan) (&(ioat_chan)->ioat_dma->pdev->dev)
>  #define to_pdev(ioat_chan) ((ioat_chan)->ioat_dma->pdev)
> diff --git a/drivers/dma/ioat/hw.h b/drivers/dma/ioat/hw.h
> index 79e4e4c09c18..0373c48520c9 100644
> --- a/drivers/dma/ioat/hw.h
> +++ b/drivers/dma/ioat/hw.h
> @@ -63,9 +63,6 @@
>  #define IOAT_VER_3_3            0x33    /* Version 3.3 */
>  #define IOAT_VER_3_4         0x34    /* Version 3.4 */
>  
> -
> -int system_has_dca_enabled(struct pci_dev *pdev);
> -
>  #define IOAT_DESC_SZ 64
>  
>  struct ioat_dma_descriptor {