Most forwarding tests invoke vrf_prepare() to set up VRF forwarding and
vrf_cleanup() to restore the original configuration. Add a helper,
adf_vrf_prepare(), which is like vrf_prepare(), but takes care of
scheduling the cleanup automatically.

Convert a number of tests that currently use defer to schedule the cleanup.

Signed-off-by: Petr Machata <[email protected]>
---

Notes:
CC: Andrew Lunn <[email protected]>
CC: Alessandro Zanni <[email protected]>
CC: Hangbin Liu <[email protected]>
CC: David Yang <[email protected]>
CC: Li Shuang <[email protected]>

 .../selftests/drivers/net/mlxsw/devlink_trap_policer.sh     | 3 +--
 tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh | 3 +--
 .../selftests/drivers/net/mlxsw/qos_max_descriptors.sh      | 3 +--
 tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh   | 3 +--
 tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh   | 3 +--
 .../selftests/net/forwarding/bridge_activity_notify.sh      | 3 +--
 .../selftests/net/forwarding/bridge_fdb_local_vlan_0.sh     | 3 +--
 tools/testing/selftests/net/forwarding/lib.sh               | 6 ++++++
 tools/testing/selftests/net/forwarding/sch_ets_core.sh      | 3 +--
 tools/testing/selftests/net/forwarding/sch_red.sh           | 3 +--
 tools/testing/selftests/net/forwarding/sch_tbf_core.sh      | 3 +--
 .../selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh       | 3 +--
 tools/testing/selftests/net/forwarding/vxlan_reserved.sh    | 3 +--
 13 files changed, 18 insertions(+), 24 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh 
b/tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh
index 29a672c2270f..6cb5a7a7438b 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh
@@ -106,8 +106,7 @@ setup_prepare()
        # Reload to ensure devlink-trap settings are back to default.
        defer devlink_reload
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh 
b/tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh
index d5b6f2cc9a29..ed217eb63cc7 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh
@@ -225,8 +225,7 @@ setup_prepare()
 
        h3mac=$(mac_get $h3)
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_max_descriptors.sh 
b/tools/testing/selftests/drivers/net/mlxsw/qos_max_descriptors.sh
index 2b5d2c2751d5..d10df3a19300 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/qos_max_descriptors.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/qos_max_descriptors.sh
@@ -178,8 +178,7 @@ setup_prepare()
 
        h2mac=$(mac_get $h2)
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh 
b/tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh
index cd4a5c21360c..6aca01ebb1ee 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh
@@ -196,8 +196,7 @@ setup_prepare()
 
        h3mac=$(mac_get $h3)
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh 
b/tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh
index 537d6baa77b7..a88d61a84b98 100644
--- a/tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh
@@ -250,8 +250,7 @@ setup_prepare()
 
        h3_mac=$(mac_get $h3)
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/net/forwarding/bridge_activity_notify.sh 
b/tools/testing/selftests/net/forwarding/bridge_activity_notify.sh
index 8ceb205fdca0..afce1c964d5a 100755
--- a/tools/testing/selftests/net/forwarding/bridge_activity_notify.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_activity_notify.sh
@@ -57,8 +57,7 @@ setup_prepare()
        swp2=${NETIFS[p3]}
        h2=${NETIFS[p4]}
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh 
b/tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh
index c1a506370c4a..052b2f757ff0 100755
--- a/tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh
@@ -98,8 +98,7 @@ setup_prepare()
        swp3=${NETIFS[p5]}
        h3=${NETIFS[p6]}
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        forwarding_enable
        defer forwarding_restore
diff --git a/tools/testing/selftests/net/forwarding/lib.sh 
b/tools/testing/selftests/net/forwarding/lib.sh
index 2c252423b326..1370d7a32655 100644
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -599,6 +599,12 @@ vrf_cleanup()
        ip -4 rule del pref 32765
 }
 
+adf_vrf_prepare()
+{
+       vrf_prepare
+       defer vrf_cleanup
+}
+
 __last_tb_id=0
 declare -A __TB_IDS
 
diff --git a/tools/testing/selftests/net/forwarding/sch_ets_core.sh 
b/tools/testing/selftests/net/forwarding/sch_ets_core.sh
index 8f9922c695b0..f9d15b2f4615 100644
--- a/tools/testing/selftests/net/forwarding/sch_ets_core.sh
+++ b/tools/testing/selftests/net/forwarding/sch_ets_core.sh
@@ -251,8 +251,7 @@ setup_prepare()
        put=$swp2
        hut=$h2
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/net/forwarding/sch_red.sh 
b/tools/testing/selftests/net/forwarding/sch_red.sh
index af166662b78a..8f79a86cb15b 100755
--- a/tools/testing/selftests/net/forwarding/sch_red.sh
+++ b/tools/testing/selftests/net/forwarding/sch_red.sh
@@ -125,8 +125,7 @@ setup_prepare()
 
        h3_mac=$(mac_get $h3)
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/net/forwarding/sch_tbf_core.sh 
b/tools/testing/selftests/net/forwarding/sch_tbf_core.sh
index ec309a5086bc..bce9ab3cb24a 100644
--- a/tools/testing/selftests/net/forwarding/sch_tbf_core.sh
+++ b/tools/testing/selftests/net/forwarding/sch_tbf_core.sh
@@ -149,8 +149,7 @@ setup_prepare()
 
        h2_mac=$(mac_get $h2)
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        h1_create
        h2_create
diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh 
b/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh
index a968a3ecbcbf..9beb5d512b8e 100755
--- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh
+++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh
@@ -371,8 +371,7 @@ setup_prepare()
        swp3=${NETIFS[p5]}
        h3=${NETIFS[p6]}
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        forwarding_enable
        defer forwarding_restore
diff --git a/tools/testing/selftests/net/forwarding/vxlan_reserved.sh 
b/tools/testing/selftests/net/forwarding/vxlan_reserved.sh
index 6fa1668986cc..c564d7a3af0b 100755
--- a/tools/testing/selftests/net/forwarding/vxlan_reserved.sh
+++ b/tools/testing/selftests/net/forwarding/vxlan_reserved.sh
@@ -88,8 +88,7 @@ setup_prepare()
        rp1=${NETIFS[p3]}
        rp2=${NETIFS[p4]}
 
-       vrf_prepare
-       defer vrf_cleanup
+       adf_vrf_prepare
 
        forwarding_enable
        defer forwarding_restore
-- 
2.49.0


Reply via email to