Jakub Kicinski wrote:
> Add a basic test suite for drivers that support PSP. Also, add a PSP
> implementation in the netdevsim driver.
>
> The netdevsim implementation does encapsulation and decapsulation of
> PSP packets, but no crypto.
>
> The tests cover the basic usage of the uapi, and demonstrate key
> exchange and connection setup. The tests and netdevsim support IPv4
> and IPv6. Here is an example run on a system with a CX7 NIC.
>
> TAP version 13
> 1..28
> ok 1 psp.data_basic_send_v0_ip4
> ok 2 psp.data_basic_send_v0_ip6
> ok 3 psp.data_basic_send_v1_ip4
> ok 4 psp.data_basic_send_v1_ip6
> ok 5 psp.data_basic_send_v2_ip4 # SKIP ('PSP version not supported',
> 'hdr0-aes-gmac-128')
> ok 6 psp.data_basic_send_v2_ip6 # SKIP ('PSP version not supported',
> 'hdr0-aes-gmac-128')
> ok 7 psp.data_basic_send_v3_ip4 # SKIP ('PSP version not supported',
> 'hdr0-aes-gmac-256')
> ok 8 psp.data_basic_send_v3_ip6 # SKIP ('PSP version not supported',
> 'hdr0-aes-gmac-256')
> ok 9 psp.data_mss_adjust_ip4
> ok 10 psp.data_mss_adjust_ip6
> ok 11 psp.dev_list_devices
> ok 12 psp.dev_get_device
> ok 13 psp.dev_get_device_bad
> ok 14 psp.dev_rotate
> ok 15 psp.dev_rotate_spi
> ok 16 psp.assoc_basic
> ok 17 psp.assoc_bad_dev
> ok 18 psp.assoc_sk_only_conn
> ok 19 psp.assoc_sk_only_mismatch
> ok 20 psp.assoc_sk_only_mismatch_tx
> ok 21 psp.assoc_sk_only_unconn
> ok 22 psp.assoc_version_mismatch
> ok 23 psp.assoc_twice
> ok 24 psp.data_send_bad_key
> ok 25 psp.data_send_disconnect
> ok 26 psp.data_stale_key
> ok 27 psp.removal_device_rx # XFAIL Test only works on netdevsim
> ok 28 psp.removal_device_bi # XFAIL Test only works on netdevsim
> # Totals: pass:22 fail:0 xfail:2 xpass:0 skip:4 error:0
> #
> # Responder logs (0):
> # STDERR:
> # Set PSP enable on device 1 to 0x3
> # Set PSP enable on device 1 to 0x0
>
> v3:
> - fix netdevsim bugs
> - rework the skipping
> - use errno
> - remove duplicated condition
> v2: https://lore.kernel.org/[email protected]
> - fix pylint warnings
> - insert CONFIG_INET_PSP in alphebetical order
> - use branch to skip all tests
> - fix compilation error when CONFIG_INET_PSP is not set
> v1: https://lore.kernel.org/[email protected]
>
> Jakub Kicinski (8):
> netdevsim: a basic test PSP implementation
> selftests: drv-net: base device access API test
> selftests: drv-net: add PSP responder
> selftests: drv-net: psp: add basic data transfer and key rotation
> tests
> selftests: drv-net: psp: add association tests
> selftests: drv-net: psp: add connection breaking tests
> selftests: drv-net: psp: add test for auto-adjusting TCP MSS
> selftests: drv-net: psp: add tests for destroying devices
>
> drivers/net/netdevsim/Makefile | 4 +
> tools/testing/selftests/drivers/net/Makefile | 10 +
> drivers/net/netdevsim/netdevsim.h | 27 +
> drivers/net/netdevsim/netdev.c | 43 +-
> drivers/net/netdevsim/psp.c | 225 +++++++
> net/core/skbuff.c | 1 +
> .../selftests/drivers/net/psp_responder.c | 483 ++++++++++++++
> .../testing/selftests/drivers/net/.gitignore | 1 +
> tools/testing/selftests/drivers/net/config | 1 +
> .../drivers/net/hw/lib/py/__init__.py | 4 +-
> .../selftests/drivers/net/lib/py/__init__.py | 4 +-
> .../selftests/drivers/net/lib/py/env.py | 4 +
> tools/testing/selftests/drivers/net/psp.py | 627 ++++++++++++++++++
> .../testing/selftests/net/lib/py/__init__.py | 2 +-
> tools/testing/selftests/net/lib/py/ksft.py | 10 +
> tools/testing/selftests/net/lib/py/ynl.py | 5 +
> 16 files changed, 1440 insertions(+), 11 deletions(-)
> create mode 100644 drivers/net/netdevsim/psp.c
> create mode 100644 tools/testing/selftests/drivers/net/psp_responder.c
> create mode 100755 tools/testing/selftests/drivers/net/psp.py
Reviewed-by: Willem de Bruijn <[email protected]>
Great both for coverage and as an example device implementation,
thanks.
I'll leave a few minor comments inline, but nothing that really needs
a respin and/or cannot be a minor fixup later.
