On 10/3/25 6:47 PM, Jakub Kicinski wrote: > Linters are still not very happy with our __init__ files, > which was pointed out in recent review (see Link). > > We have previously started importing things one by one to > make linters happy with the test files (which import from __init__). > But __init__ file itself still makes linters unhappy. > > To clean it up I believe we must completely remove the wildcard > imports, and assign the imported modules to __all__. > > hds.py needs to be fixed because it seems to be importing > the Python standard random from lib.net. > > We can't use ksft_pr() / ktap_result() in case importing > from net.lib fails. Linters complain that those helpers > themselves may not have been imported. > > Link: https://lore.kernel.org/[email protected] > Signed-off-by: Jakub Kicinski <[email protected]> > --- > - resend after net-next PR was merged > v1: https://lore.kernel.org/[email protected] > > Sending a fix for the driver's __init__.py first, if this is okay > with everyone I'll convert the rest. I'm not super confident 'cause > my Python isn't properly learned. > > Sending for net, even tho its not a real fix. I think that getting > it applied during the merge window may be okay? No strong prefence. > I'm slightly worried that merging it in net-next after the MW will > leave us with a release cycle full of merge conflicts.
AFAICS linters are indeed happy, and I agree this should go via net, to propagate the correct style ASAP on both trees. Thanks, Paolo
