2025-11-21, 01:20:33 +0100, Antonio Quartulli wrote:
> diff --git a/tools/testing/selftests/net/ovpn/common.sh
> b/tools/testing/selftests/net/ovpn/common.sh
> index 88869c675d03..b91cf17ab01f 100644
> --- a/tools/testing/selftests/net/ovpn/common.sh
> +++ b/tools/testing/selftests/net/ovpn/common.sh
[...]
> @@ -82,6 +99,23 @@ add_peer() {
> fi
> }
>
> +compare_ntfs() {
> + if [ ${#tmp_jsons[@]} -gt 0 ]; then
> + [ "$FLOAT" == 1 ] && suffix="-float"
> + expexted="json/peer${1}${suffix}.json"
nit: expected?
> + received="${tmp_jsons[$1]}"
> +
> + kill -TERM ${listener_pids[$1]} || true
> + wait ${listener_pids[$1]} || true
> + printf "Checking notifications for peer ${1}... "
> + diff <(jq -s "${JQ_FILTER}" ${expexted}) \
> + <(jq -s "${JQ_FILTER}" ${received})
> + echo "OK"
Should that OK be conditional on what diff returns?
--
Sabrina
