On Sat, Nov 22, 2025 at 6:16 PM Jakub Kicinski <[email protected]> wrote: > > netdev CI reserves SKIP in selftests for cases which can't be executed > due to setup issues, like missing or old commands. Tests which are > expected to fail must use XFAIL. > > Signed-off-by: Jakub Kicinski <[email protected]>
Good to know that, thanks ! Reviewed-by: Kuniyuki Iwashima <[email protected]> > --- > CC: [email protected] > CC: [email protected] > CC: [email protected] > CC: [email protected] > --- > tools/testing/selftests/net/af_unix/unix_connreset.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/net/af_unix/unix_connreset.c > b/tools/testing/selftests/net/af_unix/unix_connreset.c > index bffef2b54bfd..6eb936207b31 100644 > --- a/tools/testing/selftests/net/af_unix/unix_connreset.c > +++ b/tools/testing/selftests/net/af_unix/unix_connreset.c > @@ -161,8 +161,12 @@ TEST_F(unix_sock, reset_closed_embryo) > char buf[16] = {}; > ssize_t n; > > - if (variant->socket_type == SOCK_DGRAM) > - SKIP(return, "This test only applies to SOCK_STREAM and > SOCK_SEQPACKET"); > + if (variant->socket_type == SOCK_DGRAM) { > + snprintf(_metadata->results->reason, > + sizeof(_metadata->results->reason), > + "Test only applies to SOCK_STREAM and > SOCK_SEQPACKET"); > + exit(KSFT_XFAIL); > + } > > /* Close server without accept()ing */ > close(self->server); > -- > 2.51.1 >
