On Fri, 28 Nov 2025 15:44:06 -0500 Willem de Bruijn wrote:
> > import os
> > from lib.py import ksft_run, ksft_exit, ksft_pr
> > from lib.py import NetDrvEpEnv, KsftXfailEx
> > -from lib.py import cmd, defer, bkg, ip
> > +from lib.py import cmd, defer, bkg, ethtool, ip
>
> Is there a pattern behind this order. Since inserted rather than
> appended. Intended to be alphabetical?
"alphabetical if I remember"? :(
> > from lib.py import ksft_variants
> >
> >
> > @@ -70,6 +70,27 @@ from lib.py import ksft_variants
> > defer(ip, f"link set dev {dev['ifname']} mtu {dev['mtu']}",
> > host=host)
> >
> >
> > +def _set_ethtool_feat(dev, current, feats, host=None):
> > + s2n = {True: "on", False: "off"}
> > +
> > + new = ["-K", dev]
> > + old = ["-K", dev]
> > + no_change = True
> > + for name, state in feats.items():
> > + new += [name, s2n[state]]
> > + old += [name, s2n[not state]]
>
> Should the change set not only include items for which
> current != state?
>
> Now old assumes not state, but that is not necessarily true?
Good catch
