On Wed, May 20, 2026 at 4:53 PM Puranjay Mohan <[email protected]> wrote: > A single batch runs for 10ms, and batch_gen is incremented for every > batch, so for it to wrap we need to run the benchmark for 1000+ years > with a single producer.
You're right, the wraparound argument is not practically relevant here. > On CPU 0, consecutive batches with | 1: > batch_gen=2: (2 + 0) | 1 = 3, batch_hash = 3 * KNUTH > batch_gen=3: (3 + 0) | 1 = 3, batch_hash = 3 * KNUTH This is a valid issue. The proposed change introduces unwanted collisions between consecutive batch_gen values on CPU 0, which is worse than the current behavior. I'll drop this patch. Thanks for the review. Muhammad Bilal
