Hi Michael,
On Mon, 22 Oct 2007, Michael Schmitz wrote:
> But first things first - I finally had enough time to work on the platform
> driver code I need for the SMC91C111 driver aka EtherNAT driver for the
> Falcon. Here's the patch - I could only test it so far on ARAnyM, meaning
> the driver correctly fails to load because the hardware cannot be found.
> Christian may be able to build the driver and test on his Falcon before I
> get mine set up.
Ah, a clone of drivers/net/smc91x.c. Is 91x going the way of the LANCE? ;-)
> One thing that I am not entirely happy about is having the driver resource
> registered unconditionally in atari/config.c, regardless whether the
> driver is built or not. May I incude autoconf.h in the arch code? The
Thy shall not include autoconf.h ;-)
You mean <linux/config.h>? That one is auto-included these days.
Yes, you can check for CONFIG_* in arch code. But it gets messy with modules
(need to check for CONFIG_*_MODULE, too).
Alternatively, you can put the platform device in the driver. That's
what e.g. drivers/block/floppy.c does.
> other one is a kconfig issue - I need to select MMIO either as module or
> builtin, depending on how the EtherNAT driver is built. That does not
> appear to be automatic yet.
You mean MII? Doesn't `select MII' do the right thing?
> Signed-Off-By: <[EMAIL PROTECTED]>
^ ^ ^
Signed-off-by: Michael Schmitz <[EMAIL PROTECTED]>??
(That's what I changed in your other patch).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
