On Thu, Dec 22, 2011 at 08:03,  <[email protected]> wrote:
> From: Greg Ungerer <[email protected]>
>
> Compiling for the m68knommu/68328 Palm/Pilot target you get:
>
>  AS      arch/m68k/platform/68328/head-pilot.o
> arch/m68k/platform/68328/head-pilot.S:37:23: fatal error: bootlogo.rh: No 
> such file or directory
>
> The Makefile contains rules to make the bootlogo.rh file from the C source
> bootlogo.h. But it is missing a dependency that compiling head-pilot.S needs
> bootlogo.rh.
>
> Signed-off-by: Greg Ungerer <[email protected]>
> ---
>  arch/m68k/platform/68328/Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/m68k/platform/68328/Makefile 
> b/arch/m68k/platform/68328/Makefile
> index e4dfd8f..704e36d 100644
> --- a/arch/m68k/platform/68328/Makefile
> +++ b/arch/m68k/platform/68328/Makefile
> @@ -16,6 +16,9 @@ obj-$(CONFIG_ROM)     += romvec.o
>  extra-y                        := head.o
>  extra-$(CONFIG_M68328) += bootlogo.rh head.o
>
> +$(obj)/head-pilot.o: $(obj)/bootlogo.rh
> +$(obj)/head-rom.o: $(obj)/bootlogo.rh
> +
>  $(obj)/bootlogo.rh: $(src)/bootlogo.h
>        perl $(src)/bootlogo.pl < $(src)/bootlogo.h > $(obj)/bootlogo.rh

Nothing serious, you just made me wondering:
 1. Any chance bootlogo.h can be generated from a more edit-friendly format,
    cfr. drivers/video/logo/?
 2. Why do you include the *.rh file from an assembler source file, instead of
    including the *.h file from a C source file?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to