On Wed, Jul 24, 2013 at 7:23 PM, Thorsten Glaser <[email protected]> wrote:
>>The patch below adds a wrapper that copies the (supposedly short) name to
>>the kernel stack before calling into ARAnyM.
>
> Is that enough? What about buffers and all that?

As m68k doesn't support highmem, all memory buffers should point to
"normal" kernel virtual memory. If any of these were a problem, we should
have noticed already.

I had a quick look at our nf* drivers, and (unless I missed something) none
of them seem to pass pointers to static data to NF calls, except for the
ID names and the buffer in arch/m68k/emu/natfeat.c:nfprint().
The latter is OK (albeit not thread-safe, but no one calls nfprint()?),
as natfeat.c is never a module.

> Sorry, won’t be testing these patches for a while,
> I need to concentrate on the Debian sid kernel for now.

OK. Enjoy sid, thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to