On Wed, Dec 19, 2018 at 10:37 AM Geert Uytterhoeven
<ge...@linux-m68k.org> wrote:
>
> Hi Arnd,
>
> Are you seeing this issue (gcc replacing calls to strncmp() by strcmp() behind
> our back, causing link errors later), too?
>
> See also
> https://lore.kernel.org/lkml/28ebe45d-3dbd-2a82-f537-b0725f7a2...@infradead.org/
I haven't run into this one I think, but it looks like a bug in the kernel
yo me to only provide an inline version of strcmp() and not an exported symbol.
Arnd
>
> On Wed, Dec 19, 2018 at 10:32 AM Geert Uytterhoeven
> <ge...@linux-m68k.org> wrote:
> > On Wed, Dec 19, 2018 at 9:39 AM Finn Thain <fth...@telegraphics.com.au>
> > wrote:
> > > On Tue, 18 Dec 2018, John Paul Adrian Glaubitz wrote:
> > > > Could someone quickly remind me how to fix the linking issue when
> > > > building Linux 4.19
> > > > on m68k [1]?
> > > >
> > >
> > > Here's the patch that I use. I don't know what the best fix is.
> > > https://github.com/fthain/linux/commit/8fa8322eb20f8d1fdd4228742e45d0400e1dfa15
> >
> > Porbably the best fix is to follow Andreas' advice, and replace the
> > calls to strncmp() by
> > direct calls to strcmp()?
> >
> > > --
> > >
> > > > + ld -m m68kelf --build-id -X -o .tmp_vmlinux1 -T
> > > > ./arch/m68k/kernel/vmlinux.lds --whole-archive built-in.a
> > > > --no-whole-archive --start-group lib/lib.a arch/m68k/lib/lib.a
> > > > --end-group
> > > > /usr/bin/ld: block/partitions/ldm.o: in function `ldm_parse_tocblock':
> > > > ./debian/build/build_m68k_none_m68k/./block/partitions/ldm.c:153:
> > > > undefined reference to `strcmp'
> > > > /usr/bin/ld:
> > > > ./debian/build/build_m68k_none_m68k/./block/partitions/ldm.c:163:
> > > > undefined reference to `strcmp'
> > > > /usr/bin/ld: drivers/rtc/rtc-proc.o: in function `is_rtc_hctosys':
> > > > ./debian/build/build_m68k_none_m68k/./drivers/rtc/rtc-proc.c:33:
> > > > undefined reference to `strcmp'
