On Sat, 22 Dec 2018, Geert Uytterhoeven wrote:
> > - local_irq_save(flags);
> > -
> > - rom_reset();
> > -
> > - local_irq_restore(flags);
>
> I guess you removed the call to local_irq_restore() because you never
> get there anyway?
>
If a ROM call returns, we have a real problem, because we didn't call it
in an execution environment that it is designed to be called in. Anything
could happen.
Moreover, local_irq_restore() is bogus either way, given that there's
nothing that our interrupt handlers can usefully do now.
See also commit 558d5ad276c9 ("m68k/mac: Avoid soft-lockup warning after
mach_power_off").
--
