Hi Adrian,

On Wed, Sep 18, 2019 at 3:57 PM John Paul Adrian Glaubitz
<glaub...@physik.fu-berlin.de> wrote:
> On 9/18/19 3:48 PM, Geert Uytterhoeven wrote:
> >> Diffie-Hellman doing some heavy crypto lifting on a poor m68k CPU?
> >>
> >> Disable CONFIG_CRYPTO_DH?
> >
> > See also https://lists.debian.org/debian-68k/2019/04/msg00033.html
> >
> > CRYPTO_DH is selected by CRYPTO_DEV_QAT and KEY_DH_OPERATIONS.
> > The latter is bool, forcing CRYPTO_DH builtin.
> >
> > If KEY_DH_OPERATIONS needs to be enabled in a Debian kernel, perhaps
> > it can be made tristate?
> It was enabled in [1] as it's required for certain WiFi drivers [2].
>
> So, should it be fixed as you suggest or should we selectively disable it on 
> m68k?

Disabling it on m68k could be a first step (any WiFi drivers supported
on m68k yet?).

Making it tristate is non-trivial, as there are some interdependencies:

    security/keys/Makefile:compat-obj-$(CONFIG_KEY_DH_OPERATIONS) += compat_dh.o
    security/keys/Makefile:obj-$(CONFIG_KEY_DH_OPERATIONS) += dh.o
    security/keys/internal.h:#ifdef CONFIG_KEY_DH_OPERATIONS
    security/keys/keyctl.c:
(IS_ENABLED(CONFIG_KEY_DH_OPERATIONS)    ? KEYCTL_CAPS0_DIFFIE_HELLMAN
: 0) |

> > [1] 
> > https://salsa.debian.org/kernel-team/linux/commit/88f44cb9eb34098138c79bdab5fae434492866d1
> > [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911998

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to