Hello Jochen, I just reviewed this patch and here is my comments;
Jochen Friedrich wrote:
+ buf[0] = (val & 0xFF0000) >> 16;
I am not sure where it comes I have seen comments sometimes that we should use lower case hex numbers.
+ return -EREMOTEIO;
[...]
+ u8 ret, id;
Error status (-EREMOTEIO) is stored to the u8, which leads ~254. This seems not to be problem currently because mc44s803_readreg() is used only in mc44s803_attach() that returns NULL in error case. Anyhow, I think it would be better to use int for clarity.
regards, Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
