On Wed, 4 Feb 2009 22:07:44 +0000
Adam Baker <[email protected]> wrote:

> Thank You - If it wasn't for your work on gspca I'd still be using a
> buggy old driver that had no chance of making it to main line.

OK. It seems everything works fine with your webcam(s) (and the other
ones).

I added some more checks of the device presence and fixed a bit the API.

Are you ready to send me a patch for the driver?

I have just a remark: in sd_init (probe/resume), you do

        dev->work_thread = NULL;
        INIT_WORK(&dev->work_struct, sq905_dostream);

The first line is not needed, and the second should be done in
sd_config (probe only - on resume, the work will remain the same).

Also, the BUG_ON in sd_start is not needed.

About finepix, indeed, it asks for fixes, but also, it would be
simplified with a workqueue...

-- 
Ken ar c'hentaƱ |             ** Breizh ha Linux atav! **
Jef             |               http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to