On Thursday 12 March 2009 02:40:09 Patch from Sri Deevi wrote:
> The patch number 10954 was added via Mauro Carvalho Chehab
> <[email protected]> to http://linuxtv.org/hg/v4l-dvb master development
> tree.
>
> Kernel patches in this development tree may be modified to be backward
> compatible with older kernels. Compatibility modifications will be
> removed before inclusion into the mainstream Kernel
>
> If anyone has any objections, please let us know by sending a message to:
> Linux Media Mailing List <[email protected]>
Mauro,
What the hell??!
Since when does a big addition like this get merged without undergoing a
public review?
I've been working my ass off converting drivers to the new i2c API and
v4l2_subdev structures and here you merge a big driver that uses old-style
(which will lead to 'deprecated' warnings when compiling with 2.6.29, BTW),
where the driver writes directly to i2c modules instead of adding a proper
i2c module for them. And what are 'colibri', 'flatrion' and 'hammerhead'
anyway? Are they integrated devices of the cx231xx? Can they be used
separately in other products as well?
So yes, I have objections. At the minimum it should be converted first to
use v4l2_device/v4l2_subdev and I need more information on the new i2c
devices so I can tell whether the code for those should be split off into
separate i2c modules. Not to mention that I want to have the time to review
this code more closely.
Sorry Sri, this isn't your fault.
Regards,
Hans
>
> ------
>
> From: Sri Deevi <[email protected]>
> Add cx231xx USB driver
>
>
> Signed-off-by: Srinivasa Deevi <[email protected]>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
>
> ---
>
> linux/drivers/media/video/Kconfig | 2
> linux/drivers/media/video/Makefile | 1
> linux/drivers/media/video/cx231xx/Kconfig | 35
> linux/drivers/media/video/cx231xx/Makefile | 15
> linux/drivers/media/video/cx231xx/cx231xx-audio.c | 664 ++
> linux/drivers/media/video/cx231xx/cx231xx-avcore.c | 2289 ++++++++++
> linux/drivers/media/video/cx231xx/cx231xx-cards.c | 947 ++++
> linux/drivers/media/video/cx231xx/cx231xx-conf-reg.h | 491 ++
> linux/drivers/media/video/cx231xx/cx231xx-core.c | 1197 +++++
> linux/drivers/media/video/cx231xx/cx231xx-dvb.c | 566 ++
> linux/drivers/media/video/cx231xx/cx231xx-i2c.c | 580 ++
> linux/drivers/media/video/cx231xx/cx231xx-input.c | 267 +
> linux/drivers/media/video/cx231xx/cx231xx-reg.h | 1574 +++++++
> linux/drivers/media/video/cx231xx/cx231xx-vbi.c | 697 +++
> linux/drivers/media/video/cx231xx/cx231xx-vbi.h | 61
> linux/drivers/media/video/cx231xx/cx231xx-video.c | 2440 +++++++++++
> linux/drivers/media/video/cx231xx/cx231xx.h | 771 +++
> linux/include/linux/i2c-id.h | 1
> 18 files changed, 12598 insertions(+)
>
> <diff discarded since it is too big>
>
> ---
>
> Patch is available at:
> http://linuxtv.org/hg/v4l-dvb/rev/1d836224ecbf5ce6cf60696b4590630a92a4587
>5
>
> _______________________________________________
> linuxtv-commits mailing list
> [email protected]
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
