I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> Signed-off-by: Baole Ni <baolex...@intel.com> --- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 08af58f..ec9cf9aa 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -40,13 +40,13 @@ #include "s5c73m3.h" int s5c73m3_dbg; -module_param_named(debug, s5c73m3_dbg, int, 0644); +module_param_named(debug, s5c73m3_dbg, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int boot_from_rom = 1; -module_param(boot_from_rom, int, 0644); +module_param(boot_from_rom, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int update_fw; -module_param(update_fw, int, 0644); +module_param(update_fw, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define S5C73M3_EMBEDDED_DATA_MAXLEN SZ_4K #define S5C73M3_MIPI_DATA_LANES 4 -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
