Hi Mauro, Mauro Carvalho Chehab wrote: > drivers/media/i2c/ad5820.c:61:24: error: dubious one-bit signed bitfield > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > drivers/media/i2c/ad5820.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c > index 62cc1f54622f..d7ad5c1a1219 100644 > --- a/drivers/media/i2c/ad5820.c > +++ b/drivers/media/i2c/ad5820.c > @@ -58,7 +58,7 @@ struct ad5820_device { > struct mutex power_lock; > int power_count; > > - int standby : 1; > + unsigned int standby : 1;
I guess a bool would be a better match for this one. It's what it's used for. [01] assignments should be replaced by boolean values. I can submit a patch for this as well, up to you. > }; > > static int ad5820_write(struct ad5820_device *coil, u16 data) > -- Sakari Ailus sakari.ai...@linux.intel.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html