On Tue, Oct 18, 2016 at 04:24:20PM +0300, Laurent Pinchart wrote: > commit fd44aa9a254b18176ec3792a18e7de6977030ca8 upstream. > > The rcar_fcp_enable() function immediately returns successfully when the > FCP device pointer is NULL to avoid forcing the users to check the FCP > device manually before every call. However, the stub version of the > function used when the FCP driver is disabled returns -ENOSYS > unconditionally, resulting in a different API contract for the two > versions of the function. > > As a user that requires FCP support will fail at probe time when calling > rcar_fcp_get() if the FCP driver is disabled, the stub version of the > rcar_fcp_enable() function will only be called with a NULL FCP device. > We can thus return 0 unconditionally to align the behaviour with the > normal version of the function. > > Fixes: 94fcdf829793 ("[media] v4l: vsp1: Add FCP support") > Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > include/media/rcar-fcp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
What stable kernel(s) do you want this applied to? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html