Em Mon, 14 Nov 2016 09:55:48 +0000 Chris Wilson <ch...@chris-wilson.co.uk> escreveu:
> On Fri, Nov 11, 2016 at 08:50:17AM +0000, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > > > > Scatterlist entries have an unsigned int for the offset so > > correct the sg_alloc_table_from_pages function accordingly. > > > > Since these are offsets withing a page, unsigned int is > > wide enough. > > > > Also converts callers which were using unsigned long locally > > with the lower_32_bits annotation to make it explicitly > > clear what is happening. > > > > v2: Use offset_in_page. (Chris Wilson) > > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > > Cc: Pawel Osciak <pa...@osciak.com> > > Cc: Marek Szyprowski <m.szyprow...@samsung.com> > > Cc: Kyungmin Park <kyungmin.p...@samsung.com> > > Cc: Tomasz Stanislawski <t.stanisl...@samsung.com> > > Cc: Matt Porter <mpor...@kernel.crashing.org> > > Cc: Alexandre Bounine <alexandre.boun...@idt.com> > > Cc: linux-media@vger.kernel.org > > Cc: linux-ker...@vger.kernel.org > > Acked-by: Marek Szyprowski <m.szyprow...@samsung.com> (v1) > > If there were kerneldoc, it would nicely explain that having an offset > larger then a page is silly when passing in array of pages. > > Changes elsewhere look ok (personally I'd be happy with just > offset_in_page(), 4GiB superpages are somebody else's problem :) For the media changes, that looked OK. We don't have any needs to stream 4GB images nowadays :-) Reviewed-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> > -Chris > Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
