On 01/31/2017 08:30 AM, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Jan 30, 2017 at 03:06:20PM +0100, Hans Verkuil wrote:
>> From: Hans Verkuil <[email protected]>
>>
>> Document the device tree bindings for this driver.
>>
>> Mostly copied from the atmel-isc bindings.
>>
>> Signed-off-by: Hans Verkuil <[email protected]>
>> ---
>> .../devicetree/bindings/media/atmel-isi.txt | 91
>> +++++++++++++---------
>> 1 file changed, 56 insertions(+), 35 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/atmel-isi.txt
>> b/Documentation/devicetree/bindings/media/atmel-isi.txt
>> index 251f008..d1934b4 100644
>> --- a/Documentation/devicetree/bindings/media/atmel-isi.txt
>> +++ b/Documentation/devicetree/bindings/media/atmel-isi.txt
>> @@ -1,51 +1,72 @@
>> -Atmel Image Sensor Interface (ISI) SoC Camera Subsystem
>> -----------------------------------------------
>> +Atmel Image Sensor Interface (ISI)
>> +----------------------------------
>>
>> -Required properties:
>> -- compatible: must be "atmel,at91sam9g45-isi"
>> -- reg: physical base address and length of the registers set for the device;
>> -- interrupts: should contain IRQ line for the ISI;
>> -- clocks: list of clock specifiers, corresponding to entries in
>> - the clock-names property;
>> -- clock-names: must contain "isi_clk", which is the isi peripherial clock.
>> +Required properties for ISI:
>> +- compatible
>> + Must be "atmel,at91sam9g45-isi".
>> +- reg
>> + Physical base address and length of the registers set for the device.
>> +- interrupts
>> + Should contain IRQ line for the ISI.
>> +- clocks
>> + List of clock specifiers, corresponding to entries in
>> + the clock-names property;
>> + Please refer to clock-bindings.txt.
>> +- clock-names
>> + Required elements: "isi_clk".
>> +- #clock-cells
>> + Should be 0.
>
> #clock-cells can't be found in the example. Does the ISI block provide a
> #clock?
Oops, left-over from the atmel-isc.txt bindings. Removed.
>
>> +- pinctrl-names, pinctrl-0
>> + Please refer to pinctrl-bindings.txt.
>>
>> ISI supports a single port node with parallel bus. It should contain one
>> 'port' child node with child 'endpoint' node. Please refer to the bindings
>> defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
>
> We haven't documented exactly which properties are relevant for parallel
> interfaces. I think we should, but until that's done we should explicitly
> document which endpoint properties are mandatory and which are optional.
>
> Such as in Documentation/devicetree/bindings/media/i2c/nokia,smia.txt .
Done.
Thanks,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
