Hi Ramiro,

On Tue, Mar 07, 2017 at 02:37:50PM +0000, Ramiro Oliveira wrote:
> Create device tree bindings documentation for the CSI-2 Host Video
>  platform.

Extra space here.

> 
> Signed-off-by: Ramiro Oliveira <roliv...@synopsys.com>
> ---
>  .../devicetree/bindings/media/snps,plat-csi2.txt   | 77 
> ++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/snps,plat-csi2.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/snps,plat-csi2.txt 
> b/Documentation/devicetree/bindings/media/snps,plat-csi2.txt
> new file mode 100644
> index 000000000000..f559257a0a44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/snps,plat-csi2.txt
> @@ -0,0 +1,77 @@
> +Synopsys DesignWare CSI-2 Host Video Platform
> +
> +The Synopsys DesignWare CSI-2 Host Video Device subsystem comprises of 
> multiple
> +sub-devices represented by separate device tree nodes. Currently this 
> includes:
> +plat-csi2, video-device, and dw-mipi-csi.
> +
> +The sub-subdevices are defined as child nodes of the common 'camera'.
> +
> +Common 'camera' node
> +--------------------
> +
> +Required properties:
> +
> +- compatible: must be "snps,plat-csi2", "simple-bus"
> +
> +The 'camera' node must include at least one 'video-device' and one 
> 'dw-mipi-csi'
> +child node.
> +
> +'video-device' device nodes
> +-------------------
> +
> +Required properties:
> +
> +- compatible: "snps,video-device"
> +- dmas, dma-names: List of one DMA specifier and identifier string (as 
> defined
> +  in Documentation/devicetree/bindings/dma/dma.txt) per port. Each port
> +  requires a DMA channel with the identifier string set to "vdma" followed by
> +  the port index.
> +
> +Image sensor nodes
> +------------------
> +
> +The sensor device nodes should be added to their control bus controller (e.g.
> +I2C0) nodes and linked to a port node in the dw-mipi-csi,using the common 
> video
> +interfaces bindings, defined in video-interfaces.txt.

You should defined which properties you explicitly support on endpoints and
elsewhere. There are some optional ones for CSI-2, for instance.

> +
> +Example:
> +
> +
> +     camera {
> +             compatible = "snps,plat-csi2", "simple-bus";
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             ranges;

Is there something missing here?

> +                     video_device: video-device@0x10000 {
> +                             compatible = "snps,video-device";
> +                             dmas = <&axi_vdma_0 0>;
> +                             dma-names = "vdma0";
> +                     };
> +
> +                     csi2:   csi2@0x03000 {
> +                             compatible = "snps,dw-mipi-csi";
> +                             #address-cells = <1>;
> +                             #size-cells = <0>;
> +                             reg = < 0x03000 0x7FF>;
> +                             interrupts = <2>;
> +                             phys = <&mipi_phy_ctrl1 0>;
> +                             resets = <&csi2_rst 1>;
> +
> +                             output-type = <2>;
> +                             ipi-mode = <0>;
> +                             ipi-color-mode = <0>;
> +                             ipi-auto-flush = <1>;
> +                             virtual-channel = <0>;
> +
> +                             port@1 {

What are the valid ports for this device?

> +                                     reg = <1>;
> +                                     csi1_ep1: endpoint {
> +                                             remote-endpoint = <&camera>;
> +                                             data-lanes = <1 2>;
> +                                     };
> +                             };
> +                     };
> +             };
> +     };
> +
> +The dw-mipi-csi device binding is defined in snps,dw-mipi-csi.txt.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi     XMPP: sai...@retiisi.org.uk

Reply via email to