On Fri, Mar 10, 2017 at 10:32:41AM +0100, Hans Verkuil wrote: > On 09/03/17 21:45, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Mar 06, 2017 at 03:56:06PM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil <hans.verk...@cisco.com> > >> > >> Add DT support. Use it to get the reset and pwdn pins (if there are any). > >> Tested with one sensor requiring reset/pwdn and one sensor that doesn't > >> have reset/pwdn pins. > > > > If I read the datasheet right, lifting the reset signal up will reset the > > sensor but the patch doesn't make use of that, it only ensures the reset > > signal stays low. Should you lift it up for a while as well? The datasheet > > doesn't say for how long that should be done, but that it should be usable > > after 1 ms since pulling reset down. > > There does not seem to be any need for that. This sensor also comes in two > models: one with separate pwdn and reset pins, and one where it is just > hardwired. > > If the hardwired variant doesn't need a reset pulse, then neither does the > variant with pins. It works, and I am not really willing to experiment with > this.
Fine with me. Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
