Hi Sakari
On 3/7/2017 10:45 AM, Sakari Ailus wrote:
> Hi Ramiro,
>
> On Mon, Mar 06, 2017 at 11:16:34AM +0000, Ramiro Oliveira wrote:
> ...
>> +static int __sensor_init(struct v4l2_subdev *sd)
>> +{
>> + int ret;
>> + u8 resetval, rdval;
>> + struct i2c_client *client = v4l2_get_subdevdata(sd);
>> +
>> + dev_dbg(&client->dev, "sensor init\n");
>
> This looks like a debugging time leftover. Please remove.
>
Should I send a v11 with this change?
> With that,
>
> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
>
> ...
>
>> +static int ov5647_parse_dt(struct device_node *np)
>> +{
>> + struct v4l2_of_endpoint bus_cfg;
>> + struct device_node *ep;
>> +
>> + int ret;
>> +
>> + ep = of_graph_get_next_endpoint(np, NULL);
>> + if (!ep)
>> + return -EINVAL;
>> +
>> + ret = v4l2_of_parse_endpoint(ep, &bus_cfg);
>> +
>> + of_node_put(ep);
>> + return ret;
>> +}
>
> This will conflict with my fwnode patchset. Let's see in which order the
> patches will be merged, one of the sets has to be changed. The work is
> trivial though.
>
--
Best Regards
Ramiro Oliveira
ramiro.olive...@synopsys.com
