From: Hans Verkuil <hans.verk...@cisco.com>

The hdmi_power_on/off_core functions can be called multiple times:
when the HPD changes and when the HDMI CEC support needs to power
the HDMI core.

So use a counter to know when to really power on or off the HDMI core.

Also call hdmi4_core_powerdown_disable() in hdmi_power_on_core() to
power up the HDMI core (needed for CEC).

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
---
 drivers/gpu/drm/omapdrm/dss/hdmi4.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c 
b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
index 4a164dc01f15..e371b47ff6ff 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
@@ -124,14 +124,19 @@ static int hdmi_power_on_core(struct omap_dss_device 
*dssdev)
 {
        int r;
 
+       if (hdmi.core.core_pwr_cnt++)
+               return 0;
+
        r = regulator_enable(hdmi.vdda_reg);
        if (r)
-               return r;
+               goto err_reg_enable;
 
        r = hdmi_runtime_get();
        if (r)
                goto err_runtime_get;
 
+       hdmi4_core_powerdown_disable(&hdmi.core);
+
        /* Make selection of HDMI in DSS */
        dss_select_hdmi_venc_clk_source(DSS_HDMI_M_PCLK);
 
@@ -141,12 +146,17 @@ static int hdmi_power_on_core(struct omap_dss_device 
*dssdev)
 
 err_runtime_get:
        regulator_disable(hdmi.vdda_reg);
+err_reg_enable:
+       hdmi.core.core_pwr_cnt--;
 
        return r;
 }
 
 static void hdmi_power_off_core(struct omap_dss_device *dssdev)
 {
+       if (--hdmi.core.core_pwr_cnt)
+               return;
+
        hdmi.core_enabled = false;
 
        hdmi_runtime_put();
-- 
2.11.0

Reply via email to