On Tuesday 10 November 2009 07:36:22 Hiremath, Vaibhav wrote:
>
> > -----Original Message-----
> > From: Hans Verkuil [mailto:[email protected]]
> > Sent: Monday, November 09, 2009 6:42 PM
> > To: Hiremath, Vaibhav
> > Cc: [email protected]
> > Subject: Re: Finished my email backlog, let me know if I missed
> > anything
> >
> > Hi Vaibhav,
> >
> > I've reviewed these patches, see comments below.
> >
> [Hiremath, Vaibhav] Thanks a lot Hans, response in-lined below -
>
> > On Friday 06 November 2009 07:49:47 Hiremath, Vaibhav wrote:
> > >
> > > > -----Original Message-----
> > > > From: [email protected] [mailto:linux-media-
> > > > [email protected]] On Behalf Of Hans Verkuil
> > > > Sent: Thursday, November 05, 2009 10:01 PM
> > > > To: [email protected]
> > > > Subject: Finished my email backlog, let me know if I missed
> > anything
> > > >
> > > > Hi all,
> > > >
> > > > As I've been away/busy for a few weeks I had a large pile of
> > pending
> > > > emails.
> > > > I went through it all today, but if I missed anything then
> > please
> > > > remind me.
> > > >
> > > [Hiremath, Vaibhav] Hans, there are some patches which I posted
> > which need to be merged. Can you have look at it?
> > >
> > > VPFE - 6 patches
> >
> > I discovered that vpif_display.c does not compile at all due to a
> > duplicate
> > config pointer. This is both in our tree and in 2.6.32-rc6.
> >
> > I've made a patch for that. If you're OK with it then I pass it on
> > to Mauro.
> >
> [Hiremath, Vaibhav] Looks ok to me.
>
> > I also noticed that vpif_capture.c/h were missing in v4l-dvb, so I
> > copied them
> > from 2.6.32-rc6.
> >
> [Hiremath, Vaibhav] I just cross-checked in the L-o 2.6.32-rc6, and the file
> is present there. I think some commit removed these files from
> linuxtv/v4l-dvb repository, since this is only location where I don't see
> them.
>
> > > - Davinci VPFE Capture: Specify device pointer in
> > videobuf_queue_dma_contig_init
> >
> > OK.
> >
> > > - Davinci VPFE Capture:Replaced IRQ_VDINT1 with vpfe_dev-
> > >ccdc_irq1
> >
> > OK.
> >
> > > - Davinci VPFE Capture: Add support for Control ioctls[note:
> > posting again]
> >
> > Waiting for your new post.
> [Hiremath, Vaibhav] Will be sending today.
Great!
> > > - TVP514x:Switch to automode for s_input/querystd
> >
> > Reviewed. See comments in the review of this particular patch.
> >
> [Hiremath, Vaibhav] Thanks, will take it separately after closing on this.
>
> > > - Davinci VPFE Capture: Take i2c adapter id through platform data
> >
> > OK, but I split up the original patch into two: first adding the new
> > field,
> > then the arch patch can be applied, and then the final
> > vpfe_capture.c change
> > can be done. This ensures that a bisect will hopefully still work.
> >
> [Hiremath, Vaibhav] I believe you have done the splitting here, right?
> Please let me know if you want me to do something here.
That's correct, I split it up. So no need to do anything.
>
> > >
> > > OMAP - 2 patches
> > >
> > > - V4L2: Added CID's V4L2_CID_ROTATE/BG_COLOR
> >
> > OK.
> >
> > > - v4l2 doc: Added S/G_ROTATE, S/G_BG_COLOR information
> >
> > OK.
> >
> > > - V4L2: Add Capability and Flag field for Croma Key
> >
> > Missing documentation!
> >
> > BTW: the correct place to find the doc sources is in
> > linux/Documentation/DocBook/v4l/ in the master v4l-dvb mercurial
> > repository.
> >
> [Hiremath, Vaibhav] Will send today.
Good. Once I receive this one and the control patch today and assuming
there are no issues with them, then I'll add them to my repo and make a
pull request for the whole lot.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
