From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 3 Sep 2017 15:41:53 +0200

The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/pci/meye/meye.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c
index db36040770a6..9b69a07c1d5b 100644
--- a/drivers/media/pci/meye/meye.c
+++ b/drivers/media/pci/meye/meye.c
@@ -1642,14 +1642,15 @@ static int meye_probe(struct pci_dev *pcidev, const 
struct pci_device_id *ent)
        meye.vdev = meye_template;
        meye.vdev.v4l2_dev = &meye.v4l2_dev;
 
-       ret = -EIO;
-       if ((ret = sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERA, 1))) {
+       ret = sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERA, 1);
+       if (ret) {
                v4l2_err(v4l2_dev, "meye: unable to power on the camera\n");
                v4l2_err(v4l2_dev, "meye: did you enable the camera in sonypi 
using the module options ?\n");
                goto outsonypienable;
        }
 
-       if ((ret = pci_enable_device(meye.mchip_dev))) {
+       ret = pci_enable_device(meye.mchip_dev);
+       if (ret) {
                v4l2_err(v4l2_dev, "meye: pci_enable_device failed\n");
                goto outenabledev;
        }
-- 
2.14.1

Reply via email to