Hi Laurent, Thanks for the review!
On Tue, Sep 19, 2017 at 02:40:29PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:05 EEST Sakari Ailus wrote: > > Instead of using driver implementation, use > > Did you mean s/using driver implementation/using a driver implementation/ (or > perhaps "custom driver implementation") ? I think "custom driver implementation" best describes this. I'll use it. > > > v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints > > of the device. > > > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> > > Acked-by: Hans Verkuil <hans.verk...@cisco.com> > > --- > > drivers/media/platform/omap3isp/isp.c | 115 ++++++++++--------------------- > > drivers/media/platform/omap3isp/isp.h | 5 +- > > 2 files changed, 37 insertions(+), 83 deletions(-) > > > > diff --git a/drivers/media/platform/omap3isp/isp.c > > b/drivers/media/platform/omap3isp/isp.c index 1a428fe9f070..a546cf774d40 > > 100644 > > --- a/drivers/media/platform/omap3isp/isp.c > > +++ b/drivers/media/platform/omap3isp/isp.c > > [snip] > > > @@ -2256,7 +2210,9 @@ static int isp_probe(struct platform_device *pdev) > > if (ret) > > return ret; > > > > - ret = isp_fwnodes_parse(&pdev->dev, &isp->notifier); > > + ret = v4l2_async_notifier_parse_fwnode_endpoints( > > + &pdev->dev, &isp->notifier, sizeof(struct isp_async_subdev), > > + isp_fwnode_parse); > > if (ret < 0) > > The documentation in patch 05/25 states that v4l2_async_notifier_release() > should be called even if v4l2_async_notifier_parse_fwnode_endpoints() fails. > I > don't think that's needed here, so you might want to update the documentation > (and possibly the implementation of the function). > > Apart from that, > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Thanks! > > > return ret; > > > > @@ -2407,6 +2363,7 @@ static int isp_probe(struct platform_device *pdev) > > __omap3isp_put(isp, false); > > error: > > mutex_destroy(&isp->isp_mutex); > > + v4l2_async_notifier_release(&isp->notifier); > > > > return ret; > > } > > [snip] > > -- > Regards, > > Laurent Pinchart > -- Sakari Ailus sakari.ai...@linux.intel.com
