Hejssan, On 10/02/17 15:14, Niklas Söderlund wrote: > Hi Sakari, > > On 2017-10-02 14:58:10 +0300, Sakari Ailus wrote: >> Hi Niklas, >> >> On 09/30/17 16:17, Niklas Söderlund wrote: >>> Hi Sakari, >>> >>> Thanks for your patch, I like it. Unfortunately it causes issues :-( >>> >>> I picked the first 7 patches of this series on top of media-next and it >>> produce problems when tested on Koelsch with CONFIG_OF_DYNAMIC=y. >>> >>> 1. It print's 'OF: ERROR: Bad of_node_put() on /video@e6ef0000/port' >>> messages during boot. >> >> Do you have your own patch to fix fwnode_graph_get_port_parent() >> applied? I noticed it doesn't seem to be in Rob's tree; let's continue >> in the other thread. >> >> <URL:https://www.mail-archive.com/linux-media@vger.kernel.org/msg117450.html> > > To produce this issue the fix is not applied. But as I try to describe > at the end of my email applying it fixes both issues. So I think this > patch is correct (and that is why I Acked it) but my concern is that if > it's picked up before the fwnode_graph_get_port_parent() issue is sorted > out there will be problems for rcar-vin, and if possible I would like to > avoid that.
Oops. I missed that between the oops log and the patch. X-) Well, good to hear that this isn't an actual bug in this set. I'll try to be careful in sending pull requests. :-) The same issue would be present in any other driver using the new convenience functions. -- Kind regards, Sakari Ailus sakari.ai...@linux.intel.com
