Hi Jacopo,

A couple of minor language fixups inline.

On 15/11/17 10:55, Jacopo Mondi wrote:
> Add bindings documentation for Renesas Capture Engine Unit (CEU).
> 
> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
> ---
>  .../devicetree/bindings/media/renesas,ceu.txt      | 87 
> ++++++++++++++++++++++
>  1 file changed, 87 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.txt 
> b/Documentation/devicetree/bindings/media/renesas,ceu.txt
> new file mode 100644
> index 0000000..a88e9cb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,ceu.txt
> @@ -0,0 +1,87 @@
> +Renesas Capture Engine Unit (CEU)
> +----------------------------------------------
> +
> +The Capture Engine Unit is the image capture interface found on Renesas
> +RZ chip series and on SH Mobile ones.
> +
> +The interface supports a single parallel input with up 8/16bits data bus 
> width.

s/with up 8/16bits/with either 8 or 16 bits/ ?

> +
> +Required properties:
> +- compatible
> +     Must be "renesas,renesas-ceu".
> +- reg
> +     Physical address base and size.
> +- interrupts
> +     The interrupt line number.
> +- pinctrl-names, pinctrl-0
> +     phandle of pin controller sub-node configuring pins for CEU operations.
> +
> +CEU supports a single parallel input and should contain a single 'port' 
> subnode
> +with a single 'endpoint'. Optional endpoint properties applicable to parallel
> +input bus are described in "video-interfaces.txt".
> +
> +Example:
> +
> +The example describes the connection between the Capture Engine Unit and a

s/and a/and an/

> +OV7670 image sensor sitting on bus i2c1 with an on-board 24Mhz clock.
> +
> +ceu: ceu@e8210000 {
> +     reg = <0xe8210000 0x209c>;
> +     compatible = "renesas,renesas-ceu";
> +     interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&vio_pins>;
> +
> +     status = "okay";
> +
> +     port {
> +             ceu_in: endpoint {
> +                     remote-endpoint = <&ov7670_out>;
> +
> +                     bus-width = <8>;
> +                     hsync-active = <1>;
> +                     vsync-active = <1>;
> +                     pclk-sample = <1>;
> +                     data-active = <1>;
> +             };
> +     };
> +};
> +
> +i2c1: i2c@fcfee400 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&i2c1_pins>;
> +
> +     status = "okay";
> +     clock-frequency = <100000>;
> +
> +     ov7670: camera@21 {
> +             compatible = "ovti,ov7670";
> +             reg = <0x21>;
> +
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&vio_pins>;
> +
> +             reset-gpios = <&port3 11 GPIO_ACTIVE_LOW>;
> +             powerdown-gpios = <&port3 12 GPIO_ACTIVE_HIGH>;
> +
> +             clocks = <&xclk>;
> +             clock-names = "xclk";
> +
> +             xclk: fixed_clk {
> +                     compatible = "fixed-clock";
> +                     #clock-cells = <0>;
> +                     clock-frequency = <24000000>;
> +             };
> +
> +             port {
> +                     ov7670_out: endpoint {
> +                             remote-endpoint = <&ceu_in>;
> +
> +                             bus-width = <8>;
> +                             hsync-active = <1>;
> +                             vsync-active = <1>;
> +                             pclk-sample = <1>;
> +                             data-active = <1>;
> +                     };
> +             };
> +     };
> 

Reply via email to