Hi Hugues, Thanks for all your feedback, I'll merge your suggested changes in the next iteration.
On Tue, Mar 13, 2018 at 02:32:14PM +0000, Hugues FRUCHET wrote:
> > if (fi->numerator == 0) {
> > fi->denominator = maxfps;
> > fi->numerator = 1;
> > - return OV5640_30_FPS;
> > + return OV5640_60_FPS;
>
> [...]
>
> About 60 fps by default if (fi->numerator == 0): shouldn't we stick to a
> default value supported by all modes such as 30fps ?
30 fps is not supported by all modes either, so I guess 15 fps would
be a better pick?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
