On Thu, Mar 29, 2018 at 10:57:44AM +0200, Hans Verkuil wrote:
> On 29/03/18 10:45, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Wed, Mar 28, 2018 at 03:50:04PM +0200, Hans Verkuil wrote:
> > ...
> >> @@ -88,6 +96,8 @@ struct media_device_ops {
> >> * @disable_source: Disable Source Handler function pointer
> >> *
> >> * @ops: Operation handler callbacks
> >> + * @req_lock: Serialise access to requests
> >> + * @req_queue_mutex: Serialise validating and queueing requests
> >
> > s/validating and//
> >
> > As there's no more a separate validation step. Then,
>
> Well, you validate before queuing. It's not a separate step, but
> part of the queue operation. See patch 23 where this is implemented
> in the vb2_request_helper function.
Works for me. I think we'll need the validate op sooner or later anyway.
--
Sakari Ailus
sakari.ai...@linux.intel.com
